eschutho commented on issue #12566:
URL: https://github.com/apache/superset/issues/12566#issuecomment-765817337
> Would be happy to contribute the automation i'm proposing above as well.
Awesome. I'll reach out.
>
> re: "Oftentimes breaking changes are caught by reviewers/committers that
the author didn't even know of."
> That seems to suggest tags as the preferred vehicle for flagging PRs that
contribute breaking changes. A contributor may move on from the project after
adding changes that are later identified to be breaking. I think it makes sense
for committers to have oversight on ensuring those PRs are flagged after being
merged. Just my 2c.
Cool.. I think we'll need a way for the author to flag that the PR has a
breaking change, and then a committer to flag or label it as well. I'll update
the doc to suggest that we do both, and we can go from there.
>
> Somewhat tangential, but is there a way enable contributors to ask the
label bot to add a label from a defined set of "temporary/tenative labels" that
are removed at merge time? That would allow us to keep everything in tags, but
still allow contributors to identify their own open PR as potentially breaking
during the initial submission or review process.
I was thinking something similar, where if the title prefix `breaking
change:` existed for example, that the label would automatically be added, and
then a committer could remove it if the PR goes through review and the author
was able to change the PR enough to make it backward compatible or add the
label if it didn't exist. I think we'll want the label around at least until
the release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
