zhaoyongjie commented on a change in pull request #12552: URL: https://github.com/apache/superset/pull/12552#discussion_r563167607
########## File path: superset/migrations/versions/260bf0649a77_migrate_x_dateunit_in_time_range.py ########## @@ -0,0 +1,108 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""migrate [x dateunit] to [x dateunit ago/later] + +Revision ID: 260bf0649a77 +Revises: c878781977c6 +Create Date: 2021-01-23 16:25:14.496774 + +""" + +# revision identifiers, used by Alembic. +revision = "260bf0649a77" +down_revision = "c878781977c6" + +import json +import re +from sqlite3 import OperationalError + +import sqlalchemy as sa +from alembic import op +from sqlalchemy import Column, Integer, or_, Text +from sqlalchemy.dialects.mysql.base import MySQLDialect +from sqlalchemy.dialects.sqlite.base import SQLiteDialect +from sqlalchemy.ext.declarative import declarative_base + +from superset import db +from superset.utils.date_parser import DateRangeMigration + +Base = declarative_base() + + +class Slice(Base): + __tablename__ = "slices" + + id = Column(Integer, primary_key=True) + slice_name = Column(Text) + params = Column(Text) + + +def upgrade(): + bind = op.get_bind() + session = db.Session(bind=bind) + x_dateunit_in_since = DateRangeMigration.x_dateunit_in_since + x_dateunit_in_until = DateRangeMigration.x_dateunit_in_until + + if isinstance(bind.dialect, SQLiteDialect): + try: + # The REGEXP operator is a special syntax for the regexp() user function. Review comment: SQLite does not support REGEXP syntax by default. https://www.sqlite.org/lang_expr.html#regexp ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
