potiuk commented on pull request #12625: URL: https://github.com/apache/superset/pull/12625#issuecomment-766324883
> I choose 2 (periodical runs) instead of `workflow_run -> requested` event type as recommended by `potiuk/cancel-workflow-runs`'s documentation because the `cancel_duplicates` jobs trigger this way are often put into the back of the workflow queue and therefore won't be able to execute before other jobs are finished anyway. By inserting the cancel job periodically to the queue, it may have a larger chance of being actually executed. BTW. This is not necessarily true. If you have a lot of jobs in the queue and EACH of the jobs triggers "cancel" on their own, you do not need to add schedule. Whenever any of the scheduled jobs gets in the queue it will cancel all runs. And if there are no jobs in the queue, then ..... you have nothing to cancel because there are no jobs in the queue. So those scheduled cancels will only increase number of jobs but IMHO they will not increase the chance of cancel step actually running. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
