ktmud commented on a change in pull request #10270:
URL: https://github.com/apache/superset/pull/10270#discussion_r564386495
##########
File path: superset/common/query_context.py
##########
@@ -56,7 +56,7 @@ class QueryContext:
cache_type: ClassVar[str] = "df"
enforce_numerical_metrics: ClassVar[bool] = True
- datasource: BaseDatasource
+ datasource: SqlaTable
Review comment:
Right. Couldn't remember why I changed this. But whatever it was, it is
probably not needed any more.
I remember there were some discussion raised by @john-bodley around
deprecating Druid (and maybe other Datasource types) to simplify future
maintenance. Was there ever a conclusion from that, John?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
