villebro commented on a change in pull request #10270:
URL: https://github.com/apache/superset/pull/10270#discussion_r564389867
##########
File path: superset/common/query_context.py
##########
@@ -56,7 +56,7 @@ class QueryContext:
cache_type: ClassVar[str] = "df"
enforce_numerical_metrics: ClassVar[bool] = True
- datasource: BaseDatasource
+ datasource: SqlaTable
Review comment:
My impression is that no new features will be added, but we are still
not able to fully remove support quite yet. At any rate, as long as we want to
at least entertain the thought of supporting non-SQLA sources (e.g. graph
databases come to mind), I think we'll need to keep this as `BaseDatasource`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
