dpgaspar commented on a change in pull request #12760:
URL: https://github.com/apache/superset/pull/12760#discussion_r564517018
##########
File path: superset/tasks/thumbnails.py
##########
@@ -49,6 +49,7 @@ def cache_chart_thumbnail(
user = security_manager.get_user_by_username(
current_app.config["THUMBNAIL_SELENIUM_USER"], session=session
)
+ user = session.merge(user)
Review comment:
possible that the user is not bound to a session since it's outside of
the `nullpool` session block and at the end of the block the session is closed,
can you revert and test placing `screenshot.compute_and_cache` under the
`session_scope`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
