[GitHub] [superset] lyndsiWilliams opened a new pull request #12772: refactor: change Windows new tab shortcut to ctrl + q

[GitBox]

lyndsiWilliams opened a new pull request #12772:
URL: https://github.com/apache/superset/pull/12772


   ### SUMMARY
   The new tab shortcut for Windows is now `ctrl + q`.
   
   I created a `detectOS()` function in 
`superset-frontend/src/SqlLab/components/SqlEditor.jsx` that detects the user's 
OS through the browser and returns the OS as a string. I used this to create a 
ternary in the `getHotkeyConfig()` function to change the functionality of the 
new tab macro depending on the user's OS.
   
   I imported the `detectOS()` function into 
`superset-frontend/dist/src/SqlLab/components/TabbedSqlEditors.jsx` and 
`superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx` so that I could 
apply this functionality everywhere that the new tab macro occurs.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Screenshot of the tooltip while the user is not on Windows:
   <img width="569" alt="notWindows" 
src="https://user-images.githubusercontent.com/55605634/105880113-956d5380-5fc8-11eb-9671-c4641570625f.png";>
   Screenshot of the tooltip while the user is on Windows:
   <img width="569" alt="windows" 
src="https://user-images.githubusercontent.com/55605634/105880237-bf267a80-5fc8-11eb-91a2-8d6c54cc4add.png";>
   
   
   ### TEST PLAN
   Unit testing to confirm functionality is needed but not yet implemented.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org