nytai commented on a change in pull request #12772:
URL: https://github.com/apache/superset/pull/12772#discussion_r564988404
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -154,6 +154,18 @@ const defaultProps = {
scheduleQueryWarning: null,
};
+// Detects the user's OS through the browser
+export function detectOS() {
Review comment:
Using a named function also has the benefit of the name showing up in
stack traces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
