john-bodley commented on issue #12784: URL: https://github.com/apache/superset/issues/12784#issuecomment-767978889
@junlincc I was thinking something of the form: <img width="588" alt="Screen Shot 2021-01-27 at 3 43 45 PM" src="https://user-images.githubusercontent.com/4567245/105935239-7a790d00-60b6-11eb-8e80-18a2653c5213.png";> The time interval preferences and time zone topics should definitely be discussed via a SIP. The later is quite nuanced as there may be numerous times zones in consideration, i.e., i) the reference time zone of the data (e.g. what actual period a date represents), ii) the time zone of the Superset server (which is likely being used for all the server-side timestamps and the materialization of "now"), and iii) the time zone of the client. Ideally having (i), (ii), and (iii) use the safe reference is ideal and it ensures consistency throughout. It would be quite problematic if a chart was rendered based on the client time zone as two people in two different time zones would be seeing different renderings of the same chart. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4567245/105935239-7a790d00-60b6-11eb-8e80-18a2653c5213.png"](https://user-images.githubusercontent.com/4567245/105935239-7a790d00-60b6-11eb-8e80-18a2653c5213.png"){kind=link}