betodealmeida opened a new pull request #12796:
URL: https://github.com/apache/superset/pull/12796
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When we fetch samples for a given viz we need to ensure the `is_timeseries`
attribute is false, otherwise Superset will add a group by on the temporal
column, resuilting in an invalid column:
```sql
SELECT ts AS ts,
name AS name,
text AS text,
DATE(ts) AS __timestamp -- HERE
FROM
(SELECT m.ts,
c.name,
m.text
FROM messages m
JOIN channels c ON m.channel_id = c.id) AS expr_qry
WHERE ts >= STR_TO_DATE('2020-10-27 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f')
AND ts < STR_TO_DATE('2021-01-27 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f')
AND name != 'github-notifications'
GROUP BY DATE(ts) -- HERE
LIMIT 1000
```
The query above is invalid because the `GROUP BY` should contain all
non-aggregation expressions from the `SELECT`.
Because of this, some charts fail to load their samples.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Open chart and navigated to "DATA" -> "VIEW SAMPLES", now it works as
expected.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/superset/issues/12504
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
