junlincc commented on pull request #12773: URL: https://github.com/apache/superset/pull/12773#issuecomment-768865672
@adam-stasiak thank you for testing! @geido yes, 1. once a new tab is created, the underline should goes under the new tab 2. let's set both label and place holder "Tab title", it's probably more actionable 3. I also notice there is tooltip when hovering on the input. i think changing tab name is pretty self-explanatory, so let's remove it. <img width="383" alt="Screen Shot 2021-01-27 at 11 42 26 PM" src="https://user-images.githubusercontent.com/67837651/106105901-95b93c00-60f9-11eb-96cf-c8eca2855b87.png";> Thank you both! 🙏 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/106105901-95b93c00-60f9-11eb-96cf-c8eca2855b87.png"](https://user-images.githubusercontent.com/67837651/106105901-95b93c00-60f9-11eb-96cf-c8eca2855b87.png"){kind=link}