kstrz commented on a change in pull request #12762:
URL: https://github.com/apache/superset/pull/12762#discussion_r566732507



##########
File path: tests/charts/api_tests.py
##########
@@ -590,13 +679,19 @@ def test_update_chart(self):
         db.session.delete(model)
         db.session.commit()
 
+    @pytest.mark.usefixtures("load_birth_names_datasource")
     def test_update_chart_new_owner(self):
         """
         Chart API: Test update set new owner to current user
         """
+        ds_id = (

Review comment:
       I just moved it to a function to reduce repetitions. Moving it to 
`setUp` would cause need to apply fixture to all tests in class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to