TColl removed a comment on pull request #12806: URL: https://github.com/apache/superset/pull/12806#issuecomment-769824500
For what it's worth, this could be sped up further (at the expense of readability) - Would you prefer to use pandas builtins or is a dict comprehension OK here? ``` def _convert_big_integers(dframe: pd.DataFrame) -> pd.DataFrame: return pd.DataFrame( { col: dframe[col].map( lambda v: str(v) if isinstance(v, int) and abs(v) > JS_MAX_INTEGER else v ) for col in dframe.columns } ) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org