villebro commented on a change in pull request #12680:
URL: https://github.com/apache/superset/pull/12680#discussion_r566929425
##########
File path: superset/dashboards/filters.py
##########
@@ -107,8 +121,9 @@ def apply(self, query: Query, value: Any) -> Query:
query = query.filter(
or_(
Dashboard.id.in_(owner_ids_query),
- Dashboard.id.in_(published_dash_query),
+ Dashboard.id.in_(datesource_perm_query),
Dashboard.id.in_(users_favorite_dash_query),
+ Dashboard.id.in_(roles_based_query),
Review comment:
While this logic is fairly straight forward, due to this being very
critical security logic, I'd prefer to place these changes behind a FF until it
has been established to be fully safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
