willbarrett commented on a change in pull request #12762:
URL: https://github.com/apache/superset/pull/12762#discussion_r567107848
##########
File path: tests/charts/api_tests.py
##########
@@ -686,13 +793,19 @@ def test_update_chart_validate_datasource(self):
db.session.delete(chart)
Review comment:
I was thinking `finally` in a `try` block, yes, in an attempt to isolate
test failures. Cascading failures make the test suite much more challenging to
work with on a day to day basis - lots to dig through to figure out the issue.
I'm not sure what the best refactor here is to ensure cleanup without bloating
the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
