junlincc edited a comment on pull request #12782: URL: https://github.com/apache/superset/pull/12782#issuecomment-770110781
> And FYI, one of the motivation behind [SIP-43](https://github.com/apache/superset/issues/9887) was to have the ability to retain control values when switching viz types: > > > This not only greatly simplifies the code, but also makes it easier to switch between visualization types---all control values for Query, Transform, and even Columns can be easily retained. > > I think it would make sense to extend that ability to datasource switch, too. Right, that's the goal. In terms of timeline, it probably will happen naturally after Echarts migration and dynamic control that @villebro proposed. Well actually it's already happening in Time-series Echarts. Really appreciate your suggestions though! since chart creation flow is still fairly broken, and the lack of consistency in control fields across different chart types, it makes more sense reseting to default when switching dataset for now. @pkdotson please address @villebro's comment, then we are good to go. thanks you both! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
