[GitHub] [superset] maloun96 commented on a change in pull request #12859: Fix: Add inclusive and exclusive text for date start and end

Mon, 01 Feb 2021 01:09:24 -0800 


maloun96 commented on a change in pull request #12859:
URL: https://github.com/apache/superset/pull/12859#discussion_r567661167



##########
File path: 
superset-frontend/src/explore/components/controls/DateFilterControl/frame/AdvancedFrame.tsx
##########
@@ -20,6 +20,7 @@ import React from 'react';
 import { t } from '@superset-ui/core';
 import { SEPARATOR } from 'src/explore/dateFilterUtils';
 import { Input } from 'src/common/components';
+import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';

Review comment:
       The reason I added InfoTooltipWithTrigger instead of InfoTooltip is from 
style
   Start = InfoTooltip
   End = InfoTooltipWithTrigger
   
![image](https://user-images.githubusercontent.com/8277264/106437100-921d1080-647d-11eb-9ff1-32e03c1318ba.png)
   
   and it doesn't make sense to create custom styles for the control label to 
arrange the tooltip icon.
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to