[GitHub] [superset] simcha90 commented on a change in pull request #12857: refactor(color-schemes): refactor setting of color schemes

Mon, 01 Feb 2021 01:36:44 -0800 


simcha90 commented on a change in pull request #12857:
URL: https://github.com/apache/superset/pull/12857#discussion_r567680001



##########
File path: superset-frontend/src/setup/setupColors.ts
##########
@@ -16,36 +16,39 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import airbnb from 
'@superset-ui/core/esm/color/colorSchemes/categorical/airbnb';
-import categoricalD3 from 
'@superset-ui/core/esm/color/colorSchemes/categorical/d3';
-import echarts from 
'@superset-ui/core/esm/color/colorSchemes/categorical/echarts';
-import google from 
'@superset-ui/core/esm/color/colorSchemes/categorical/google';
-import lyft from '@superset-ui/core/esm/color/colorSchemes/categorical/lyft';
-import preset from 
'@superset-ui/core/esm/color/colorSchemes/categorical/preset';
-import sequentialCommon from 
'@superset-ui/core/esm/color/colorSchemes/sequential/common';
-import sequentialD3 from 
'@superset-ui/core/esm/color/colorSchemes/sequential/d3';
+import airbnb from 
'@superset-ui/core/lib/color/colorSchemes/categorical/airbnb';
+import categoricalD3 from 
'@superset-ui/core/lib/color/colorSchemes/categorical/d3';
+import echarts from 
'@superset-ui/core/lib/color/colorSchemes/categorical/echarts';
+import google from 
'@superset-ui/core/lib/color/colorSchemes/categorical/google';
+import lyft from '@superset-ui/core/lib/color/colorSchemes/categorical/lyft';
+import preset from 
'@superset-ui/core/lib/color/colorSchemes/categorical/preset';
+import sequentialCommon from 
'@superset-ui/core/lib/color/colorSchemes/sequential/common';
+import sequentialD3 from 
'@superset-ui/core/lib/color/colorSchemes/sequential/d3';
 import {
+  CategoricalScheme,
   getCategoricalSchemeRegistry,
   getSequentialSchemeRegistry,
+  SequentialScheme,
 } from '@superset-ui/core';
-import superset from 
'@superset-ui/core/esm/color/colorSchemes/categorical/superset';
+import superset from 
'@superset-ui/core/lib/color/colorSchemes/categorical/superset';
+import ColorScheme from '@superset-ui/core/lib/color/ColorScheme';
 
 export default function setupColors(
-  extraCategoricalColorSchemas,
-  extraSequentialColorSchemes,
+  extraCategoricalColorSchemas: ColorScheme[] = [],
+  extraSequentialColorSchemes: ColorScheme[] = [],

Review comment:
       These interfaces are not imported from superset-ui
   
![image](https://user-images.githubusercontent.com/56388545/106440609-b5e25580-6481-11eb-95f8-56e10395aa9b.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to