ktmud commented on a change in pull request #12865:
URL: https://github.com/apache/superset/pull/12865#discussion_r568056187
##########
File path: superset/commands/exceptions.py
##########
@@ -85,6 +85,13 @@ def __init__(self) -> None:
super().__init__([_("Owners are invalid")], field_name="owners")
+class RolesNotFoundValidationError(ValidationError):
+ status = 422
+
+ def __init__(self) -> None:
+ super().__init__([_("Roles are invalid")], field_name="roles")
Review comment:
Nit suggestion:
```suggestion
super().__init__([_("Some roles do not exist")], field_name="roles")
```
As roles can be invalid in many ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
