suddjian commented on issue #12566: URL: https://github.com/apache/superset/issues/12566#issuecomment-771205948
> @eschutho I think we can revisit this after this part is done: > > > We also need more thorough documentation of what exactly is included in the plugin interface in order to really determine if a change to the interface is breaking for plugins or not. > > However, IMHO, the plugin system still need some major refinement (e.g.[ simplify the registry](https://github.com/apache-superset/superset-ui/issues/902#issuecomment-761932903), async loading for controls and `transformProps`, typing enhancement, shared control refactoring/cleanup, mono-repo, etc), and I'm afraid attending to breaking changes add new obstacles to some already very challenging work. I agree that it needs refinement and should avoid creating obstacles for ourselves on something this unpolished. But if we can start with a narrow definition of what is public and what constitutes a major change, rather than an anything goes approach, it will give us a basis to move forward and clear reasoning for including most changes in a minor release. This gives plugin authors the confidence they need, and I believe will help us to better expand the API. For now, I think this could be as limited as the `ChartPlugin` class and its constructor arguments. I don't think the registries should be considered public APIs, since they don't need to be used directly when writing a plugin. That is just my opinion, I also don't mind leaving the public plugin interface undefined for the time being. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
