simcha90 commented on a change in pull request #12199:
URL: https://github.com/apache/superset/pull/12199#discussion_r568338774
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/types.ts
##########
@@ -78,15 +82,15 @@ export type FilterType = 'text' | 'date';
export interface Filter {
allowsMultipleValues: boolean;
cascadeParentIds: string[];
- defaultValue: string | null;
- currentValue?: (string | number | boolean)[] | null;
+ defaultValue: any;
+ currentValue?: any;
Review comment:
it's value that we are passing to the native filter, so it should be
`currentValue` together with `defaultValue` and not `currentState` according
current apis
I think may be we need to discuss in future if we want to render some things
like `Allow multiple selection` checkbox inside of native filter chart so it
should be really changed to currentState but for now all filters working only
with `currentValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
