dpgaspar commented on a change in pull request #12869:
URL: https://github.com/apache/superset/pull/12869#discussion_r568514796
##########
File path: superset/db_engine_specs/base.py
##########
@@ -177,6 +178,35 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
),
}
+ @classmethod
+ def get_dbapi_exception_mapping(cls) -> Dict[Type[Exception],
Type[Exception]]:
+ """
+ Each engine can implement and converge it's own specific exceptions
into
Review comment:
Fixed, yes that's a good point, a simple way of doing it is:
```
if not new_exception:
return SupersetDBAPIError(str(exception))
```
But can have broader implications, I want to place the base for this, and
just interfere on the defined exceptions for Elasticsearch and clickhouse (for
now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
