ktmud opened a new pull request #12936: URL: https://github.com/apache/superset/pull/12936
### SUMMARY Follow up of #12930 . Fix the table chart E2E test currently failing in master. The test expects table chart to be sorted by first metric in descending order when a "Sort by" metric is not set, regardless of if "Sort descending" is selected. This is the original logic pre table chart API migration (#10270). Needs to wait for https://github.com/apache-superset/superset-ui/pull/935 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### After Correctly sorted by first metric in descending order:  #### Before Incorrectly sort by first metric in ascending order. ### TEST PLAN CI and 1. Go to table chart 2. Select a metric, don't select sort by metric, **don't check "sort descending"** 3. Your chart should sort by first metric in **descending** order ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
