ktmud commented on a change in pull request #12933:
URL: https://github.com/apache/superset/pull/12933#discussion_r570010921
##########
File path: superset/utils/core.py
##########
@@ -1401,19 +1402,30 @@ def get_column_names_from_metrics(metrics:
List[Metric]) -> List[str]:
return columns
-def serialize_pandas_dtypes(dtypes: List[np.dtype]) -> List[GenericDataType]:
- """Serialize pandas/numpy dtypes to JavaScript types"""
- mapping = {
- "object": GenericDataType.STRING,
- "category": GenericDataType.STRING,
- "datetime64[ns]": GenericDataType.TEMPORAL,
- "int64": GenericDataType.NUMERIC,
- "in32": GenericDataType.NUMERIC,
- "float64": GenericDataType.NUMERIC,
- "float32": GenericDataType.NUMERIC,
- "bool": GenericDataType.BOOLEAN,
+def extract_dataframe_dtypes(df: pd.DataFrame) -> List[GenericDataType]:
+ """Serialize pandas/numpy dtypes to generic types"""
+
+ # omitting string types as those will be the default type
+ inferred_type_map: Dict[str, GenericDataType] = {
+ "floating": GenericDataType.NUMERIC,
+ "integer": GenericDataType.NUMERIC,
+ "mixed - integer": GenericDataType.NUMERIC,
+ "mixed - integer - float": GenericDataType.NUMERIC,
Review comment:
Should be `mixed-integer` and `mixed-integer-float`. And `mixed-integer`
should probably be string since `infer_dtype(['a','b','c',1])` and
`infer_dtype(['a','b','c',1, 1.1])` are also `mixed-integer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
