AAfghahi commented on pull request #12956: URL: https://github.com/apache/superset/pull/12956#issuecomment-773707112
The mockups are 2px because that looked closer to the figma. On Thu, Feb 4, 2021, 19:47 Elizabeth Thompson <[email protected]> wrote: > *@eschutho* commented on this pull request. > ------------------------------ > > In superset-frontend/src/common/components/Dropdown.tsx > <https://github.com/apache/superset/pull/12956#discussion_r570645309>: > > > margin: 0; > border-radius: ${({ theme }) => > `0 ${theme.gridUnit}px ${theme.gridUnit}px 0`}; > width: ${({ theme }) => theme.gridUnit * 9}px; > &:before, > &:hover:before { > - border-left: 1px solid ${({ theme }) => theme.colors.grayscale.light5}; > + border-left: 2px solid ${({ theme }) => theme.colors.grayscale.light5}; > > Are the mockups 1 or 2px border? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/superset/pull/12956#pullrequestreview-583936177>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALVKTWAUH5OCL65ZQSGVE7LS5M53PANCNFSM4XDYRD2Q> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
