villebro commented on a change in pull request #12937:
URL: https://github.com/apache/superset/pull/12937#discussion_r570063554
##########
File path: superset/viz.py
##########
@@ -1456,7 +1456,7 @@ def get_data(self, df: pd.DataFrame) -> VizData:
data.append(
{
- "key": prefix + ", ".join(series["key"]),
+ "key": prefix + "".join(series["key"]),
Review comment:
Good catch; I believe the key can be both `str` and `List[str]`. Due to
`viz.py` not being actively maintained and being light on tests it might be a
good idea to add some additional logic to guard against regressions. Perhaps we
should do something like this (probably makes sense to break out
`series["key"]` into a variable to avoid duplication):
```suggestion
"key": prefix + ", ".join(series["key"] if
isinstance(series["key"], list) else [series["key"]]),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
