simcha90 opened a new pull request #12992:
URL: https://github.com/apache/superset/pull/12992


   ### SUMMARY
   This PR is continue of @agatapst PR: 
https://github.com/apache/superset/pull/12946
   
   Here description of ☝️ PR:
   ```
   The aim of this PR was to create foundations for new native filters' 
feature: time filters.
   User can choose between one more filter type, which is Time.
   
   That's the basics for this feature. What should be added in next PRs:
   
   UI improvements (if we want to show modal in modal, how to display very long 
time "pills" in Filter Bar etc.)
   Improve Filter Config Modal validation - right now datasource is required, 
but in case of time filters it should not
   Implement additional filtering: i.e. inverse
   Might also take a look on performance - it take more time to show time 
filters result than select filters result
   Filter indicator logic needs to be updated
   ```
   
   In addition this PR fix some edge cases.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to