zhaoyongjie commented on a change in pull request #12992:
URL: https://github.com/apache/superset/pull/12992#discussion_r572014065
##########
File path:
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterControl.tsx
##########
@@ -168,13 +168,20 @@ const IconWrapper = styled.span`
interface DateFilterLabelProps {
name: string;
onChange: (timeRange: string) => void;
+ onTimeRangeChange?: (textValue?: string, timeRange?: string) => void;
Review comment:
`onChange` and `onTimeRangeChange` seem to have the same function, can
we merge these props?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
