AAfghahi removed a comment on pull request #13008: URL: https://github.com/apache/superset/pull/13008#issuecomment-775342375
:) Thank you, though that was Elizabeth's suggestion! On Mon, Feb 8, 2021 at 1:13 PM Beto Dealmeida <[email protected]> wrote: > *@betodealmeida* approved this pull request. > > > <https://camo.githubusercontent.com/ccb7068a31492e3e9e8ec7ee0dc2d17a634b8636ae07f7f45412135dbd4b39e0/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f4a5664463134435151483767732f736f757263652e676966> > ------------------------------ > > In superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx > <https://github.com/apache/superset/pull/13008#discussion_r572260895>: > > > @@ -91,25 +91,32 @@ const RunQueryActionButton = ({ > ? (DropdownButton as React.FC) > : Button; > > + const isDisabled = !sql.trim(); > > Nice, this is way more readable now, and the intent is clear! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/superset/pull/13008#pullrequestreview-585782852>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALVKTWA7NZYY6NG2QKB3P7TS6AST5ANCNFSM4XJOAE2Q> > . > -- Arash Afghahi ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
