simcha90 opened a new pull request #13021: URL: https://github.com/apache/superset/pull/13021
### SUMMARY This PR decouple hardcoded per filter params from Filter config modal. Now they generated dynamically based on `controlPanel` config. In first phase we take all params that have `renderTrigger` property and render then in the bottom of the Modal. also we added new property `resetConfig` to reset `defaultValue` if current property is changed ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/56388545/107328399-530f4080-6ab7-11eb-891b-9e7e9427c4aa.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
