kgabryje opened a new pull request #13029: URL: https://github.com/apache/superset/pull/13029
### SUMMARY Filter suggestions endpoint has a 10k limit of returned results. If there are more than 10k possible values and the searched value is at the end of the list, it will not be returned and the user won't be able to select it when using a single value operator. This PR implements a "hack", which creates an additional option based on current search input, thus allowing to select it. I consider this a temporary solution. Optimally, we should make the `/superset/filter/` endpoint accept a search query param and use it to filter the results. Then we can refactor `src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent.jsx` to send a request for suggestions when a user types a query (with some debounce for optimization). This PR also fixes the issue with warning tooltip mentioned in https://github.com/apache/superset/issues/13017#issuecomment-775607176. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes https://github.com/apache/superset/issues/13017 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
