[GitHub] [superset] michael-s-molina opened a new pull request #13037: feat: add autocopy functionality to CopyToClipboard (#10328)

[GitBox]

michael-s-molina opened a new pull request #13037:
URL: https://github.com/apache/superset/pull/13037


   ### SUMMARY
   - Adds autocopy functionality to `CopyToClipboard` (#10328)
   - Fixes a bug where the copying was being called twice
   - Changes `copyTextToClipboard` in `copy.ts` to be asynchronous and fixed 
promise type
   - Adjusts the margin of buttons that contain an icon but no text
   - Changes copy feedback to use notifications instead of tooltip changes
   
   I left the copy button in autocopy mode just in case the user navigates to 
another tab, copy some content, comes back to the application and wants to copy 
the link again without reopening the modal or popover.
   
   [Alert PR](https://github.com/apache/superset/pull/12122) improves 
notification positioning with right and bottom margins helping the user to 
notice the message.
   
   @junlincc @rusackas 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1773" alt="Screen Shot 2021-02-09 at 4 17 48 PM" 
src="https://user-images.githubusercontent.com/70410625/107416856-b8812280-6af3-11eb-898f-67e0ff62a3b3.png";>
   <img width="1782" alt="Screen Shot 2021-02-09 at 4 28 09 PM" 
src="https://user-images.githubusercontent.com/70410625/107416940-d77fb480-6af3-11eb-9e68-3e08a665f19b.png";>
   <img width="1772" alt="Screen Shot 2021-02-09 at 4 21 32 PM" 
src="https://user-images.githubusercontent.com/70410625/107416976-e0708600-6af3-11eb-9556-8151fe6a6cf8.png";>
   <img width="1787" alt="Screen Shot 2021-02-09 at 4 23 29 PM" 
src="https://user-images.githubusercontent.com/70410625/107416996-e6666700-6af3-11eb-84e8-7f9cb32385bb.png";>
   
   ### TEST PLAN
   1 - Go to a dashboard
   2- Click on a chart 3 dots icon
   3 - Select share chart
   4 - The link should be automatically copied to clipboard
   
   1 - Go to explore
   2 - Click on chain icon in top right corner 
   3 - The link should be automatically copied to clipboard
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org