ktmud commented on a change in pull request #12918:
URL: https://github.com/apache/superset/pull/12918#discussion_r573271172
##########
File path: superset-frontend/src/utils/common.ts
##########
@@ -44,7 +44,13 @@ export function getParamFromQuery(query, param) {
return null;
}
-export function storeQuery(query) {
+export function storeQuery(query: {
+ dbId: any;
+ title: any;
+ schema: any;
+ autorun: any;
+ sql: any;
+}) {
Review comment:
https://github.com/apache/superset/blob/9997abeab6a5016f07872e9741f2bfba1686895f/superset-frontend/src/SqlLab/components/ShareSqlLabQuery.jsx#L34-L41
Maybe make the typing consistent with here?
To avoid having to update typing for all other util functions, you may also
create `getParamFromQuery` as its own file. I think in general we should
welcome smaller util files so it's easier to maintain and search (to find a
specific util function you can just search by file name instead of search file
content).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
