AAfghahi commented on pull request #13032: URL: https://github.com/apache/superset/pull/13032#issuecomment-776369862
Yes, I would be happy to do that. I was running into that with the other component that I was working on as well. On Tue, Feb 9, 2021 at 6:51 PM Elizabeth Thompson <[email protected]> wrote: > *@eschutho* commented on this pull request. > ------------------------------ > > In superset-frontend/src/SqlLab/components/HighlightedSql.jsx > <https://github.com/apache/superset/pull/13032#discussion_r573336259>: > > > > - render() { > - return ( > + const [modalTrigger, setModalTrigger] = useState( > > can we put this up under line 45 just by convention? We can add a lint > rule for this in the future. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/superset/pull/13032#pullrequestreview-587125806>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALVKTWE4F5B4C2M3VGKSYKDS6HDAJANCNFSM4XLMX6FA> > . > -- Arash Afghahi ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
