ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574181082
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one
metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't
overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
Or we can keep it as `timeseries_limit_metric` to be able to reuse the
existing code and do a wholesale migration later.
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one
metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't
overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
cc @villebro what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
