geido commented on a change in pull request #12773:
URL: https://github.com/apache/superset/pull/12773#discussion_r574316992
##########
File path: superset-frontend/src/components/EditableTitle.tsx
##########
@@ -23,28 +23,33 @@ import TooltipWrapper from './TooltipWrapper';
interface EditableTitleProps {
canEdit?: boolean;
+ editing?: boolean;
emptyText?: string;
extraClasses?: Array<string> | string;
multiLine?: boolean;
noPermitTooltip?: string;
onSaveTitle: (arg0: string) => {};
showTooltip?: boolean;
style?: object;
- title: string;
+ title?: string;
+ defaultTitle?: string;
+ placeholder?: string;
}
export default function EditableTitle({
canEdit = false,
- emptyText,
+ editing = false,
extraClasses,
multiLine = false,
noPermitTooltip,
onSaveTitle,
showTooltip = true,
style,
- title,
+ title = '',
+ defaultTitle = '',
+ placeholder = '',
Review comment:
@junlincc @rusackas the component is used by several others. In order to
safely apply these changes to the tabs titles only, a separation between title
and defaultTitle needs to be made. If we want to change them all in the future,
this can be consolidated and one of the two removed. That is not the case now
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
