dpgaspar commented on a change in pull request #13075:
URL: https://github.com/apache/superset/pull/13075#discussion_r574449881
##########
File path: scripts/ci_check_no_file_changes.sh
##########
@@ -44,11 +39,25 @@ do
echo "Invalid check: \"${CHECK}\". Falling back to exiting with FAILURE
code"
exit 1
fi
+ REGEXES=(${REGEXES[@]} ${REGEX})
Review comment:
nit: shellcheck complains about:
```
REGEXES=(${REGEXES[@]} ${REGEX})
^-----------^ SC2206: Quote to prevent word splitting/globbing,
or split robustly with mapfile or read -a.
^------^ SC2206: Quote to prevent word
splitting/globbing, or split robustly with mapfile or read -a.
```
##########
File path: scripts/ci_check_no_file_changes.sh
##########
@@ -44,11 +39,25 @@ do
echo "Invalid check: \"${CHECK}\". Falling back to exiting with FAILURE
code"
exit 1
fi
+ REGEXES=(${REGEXES[@]} ${REGEX})
+done
+echo
- if [[ "${FILES}" =~ ${REGEX} ]]; then
- echo "Detected changes... Exiting with FAILURE code"
- exit 1
- fi
+cat<<EOF
+CHANGED FILES:
+$FILES
+
+EOF
+
+for FILE in ${FILES}
+do
+ for REGEX in ${REGEXES[@]}
Review comment:
nit:
```
In 1.sh line 54:
for REGEX in ${REGEXES[@]}
^-----------^ SC2068: Double quote array expansions to avoid
re-splitting elements.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
