villebro commented on a change in pull request #13090:
URL: https://github.com/apache/superset/pull/13090#discussion_r575157301
##########
File path: tests/reports/commands_tests.py
##########
@@ -342,6 +342,11 @@ def create_no_alert_email_chart(request):
"validator_type": ReportScheduleValidatorType.NOT_NULL,
"validator_config_json": "{}",
},
+ "alert7": {
+ "sql": "SELECT first from test_table where first=0",
Review comment:
If this is supposed to return zero rows, would a more obvious false
where clause be more descriptive? Something like `where 1 = 0`? The other
examples above are easy to reason about as they have a static query that
doesn't reference a table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
