[GitHub] [superset] junlincc edited a comment on pull request #13109: fix(FilterBox): treat empty defaultValues as null

[GitBox]

junlincc edited a comment on pull request #13109:
URL: https://github.com/apache/superset/pull/13109#issuecomment-778913892


   Thanks for the fix and house keeping! 
   After I select a default filter, there's no option showing in dropdown in 
Filterbox or Dashboard.  not sure this is related to your change. 
   <img width="1920" alt="Screen Shot 2021-02-14 at 7 21 29 PM" 
src="https://user-images.githubusercontent.com/67837651/107901973-fddd8f80-6ef9-11eb-9f23-14bb69cfc6cf.png";>
   <img width="1918" alt="Screen Shot 2021-02-14 at 7 21 15 PM" 
src="https://user-images.githubusercontent.com/67837651/107901981-00d88000-6efa-11eb-85ad-600dfc70a291.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org