simcha90 opened a new pull request #13148: URL: https://github.com/apache/superset/pull/13148
### SUMMARY This PR decouple decouple filter params from native filters config modal. In this phase we decoupled datasource based on `datasourceCount` property that exported from every viz-plugin More changes: - we update filter badge logic for a case if filter doesn't have datasource, in this case we show applied indicator if this chart affected by scope - we build filter types dropdown in filter config modal based on behavior property exported from viz-plugin ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/56388545/108049050-748ca100-7050-11eb-91c9-9b6c47551894.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
