Yann-OAF commented on pull request #13116: URL: https://github.com/apache/superset/pull/13116#issuecomment-779835811
> LGTM, the suggestion on how to add the webdriver is not ideal. Calling @craig-rueda here for some additional thoughts Yes I definitely agree... installing stuff at runtime isn't a really good practice since it creates extra risks. The best would really be to have a pre-built image for it, but I'm not aware of any official ones, and this is out of scope of this PR anyway... Btw I would argue that the same goes for the way extra pip packages (which also requires running the containers as `root`...) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
