iercan opened a new pull request #13157:
URL: https://github.com/apache/superset/pull/13157


   ### SUMMARY
   This PR resolves #13097
   This improvements make thumbnails and new reports module uses 
WEBDRIVER_WINDOW option from config. I also changed default values to more 
proper values according to my tests. 
   
   I defined init function to screenshot object to pass window_size and 
thumb_size same value for reports so that images will not be shrink . Before It 
was using harcoded 800x600 value which is defined for thumbnails. 
   
   Additional note: This PR will cause thumbnails recalculate because cache 
keys depends on window size. 
   
   ### TEST PLAN
   Create alert and reports. Images should send the same size defined with 
WEBDRIVER_WINDOW
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to