villebro commented on a change in pull request #13153:
URL: https://github.com/apache/superset/pull/13153#discussion_r577437763
##########
File path: superset/db_engine_specs/base.py
##########
@@ -933,6 +933,9 @@ def execute(cls, cursor: Any, query: str, **kwargs: Any) ->
None:
:param kwargs: kwargs to be passed to cursor.execute()
:return:
"""
+ if not cls.allows_sql_comments:
+ query = sql_parse.ParsedQuery(query).strip_comments()
Review comment:
I support the idea of doing a quick char check, best of both worlds 👍
Also, I'm assuming this is a temporary fix, so we should be able to disable it
when/if your request is implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
