michael-s-molina commented on a change in pull request #13176: URL: https://github.com/apache/superset/pull/13176#discussion_r577743538
########## File path: superset-frontend/src/components/Popover/Popover.test.tsx ########## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen, waitFor } from 'spec/helpers/testing-library'; +import userEvent from '@testing-library/user-event'; +import { supersetTheme } from '@superset-ui/core'; +import Icon from 'src/components/Icon'; +import Button from 'src/components/Button'; +import Popover from '.'; + +test('should render', () => { + const { container } = render(<Popover />); + expect(container).toBeInTheDocument(); +}); + +test('should render a title when visible', () => { + render(<Popover title="Popover title" visible />); + expect(screen.getByText('Popover title')).toBeTruthy(); +}); + +test('should render some content when visible', () => { + render(<Popover content="Content sample" visible />); + expect(screen.getByText('Content sample')).toBeTruthy(); +}); + +test('it should not render a title or content when not visible', () => { + render(<Popover content="Content sample" title="Popover title" />); + const content = screen.queryByText('Content sample'); + const title = screen.queryByText('Popover title'); + expect(content).not.toBeInTheDocument(); + expect(title).not.toBeInTheDocument(); +}); + +test('renders with icon child', async () => { Review comment: Don't need to be async ########## File path: superset-frontend/src/components/Popover/Popover.stories.tsx ########## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import Button from 'src/components/Button'; +import { PopoverProps } from 'antd/lib/popover'; +import React from 'react'; +import Popover from '.'; + +export default { + title: 'Popover', + component: Popover, +}; + +export const InteractivePopover = ( + args: JSX.IntrinsicAttributes & PopoverProps & React.RefAttributes<unknown>, Review comment: Do you need these intersections? Shouldn't `PopoverProps` be sufficient? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
