betodealmeida opened a new pull request #13216:
URL: https://github.com/apache/superset/pull/13216


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   The migration script `b56500de1855_add_uuid_column_to_import_mixin.py` has a 
try/except block when adding the `uuid` column to tables; if the operation 
fails the script might succeed depending on the error. Because of this, people 
who have ran the migration are having problems running Superset because of 
missing columns.
   
   I fixed the script by removing the try/except block, and adding a new script 
that adds the column wherever necessary.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   1. Ran migration, nothing happened as expected (since all my tables have the 
uuid column)
   2. Downgraded to 070c043f2fdb and deleted the `uuid` column from the 
`dashboards` table
   3. Ran migration, and verified that `uuid` was added to `dashboards` and 
populated.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to