eschutho commented on a change in pull request #13219:
URL: https://github.com/apache/superset/pull/13219#discussion_r578650804
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -413,11 +414,13 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
<div className="helper">
{t('Refer to the ')}
<a
- href={conf?.SQLALCHEMY_DOCS_URL ?? ''}
+ href={documentationLink}
target="_blank"
rel="noopener noreferrer"
>
- {t('SQLAlchemy docs')}
+ {documentationLink.includes('sqlalchemy')
+ ? t('SQLAlchemy docs')
+ : t('Connection Strings documentation')}
Review comment:
what do you think about putting the text in the config as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
