willbarrett commented on a change in pull request #13212: URL: https://github.com/apache/superset/pull/13212#discussion_r578776134
########## File path: tests/security/api_tests.py ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# isort:skip_file +# pylint: disable=too-many-public-methods, no-self-use, invalid-name, too-many-arguments +"""Unit tests for Superset""" +import json +from tests.base_tests import SupersetTestCase +from flask_wtf.csrf import generate_csrf + + +class TestSecurityApi(SupersetTestCase): + resource_name = "security" + + def test_get_dashboard(self): Review comment: nit: test name It might be good to add a test for the failure case where the user is not authorized. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
