ktmud commented on pull request #13189: URL: https://github.com/apache/superset/pull/13189#issuecomment-781702729
> Ideally, yes, but there's no way (that I've found) for an `issue_comment` event to reference workflow runs for a PR, making it impossible to retrieve the uploaded build artifacts. > You can potentially get the branch name of the PR first, then find the workflow runs by branch name. I've done that in the `cancel_github_workflow` script: https://github.com/apache/superset/blob/2456a2eb99d0abdeec12a5e5c889d418f27e2c74/scripts/cancel_github_workflows.py#L176-L183 > Not sure how this would work in a PR context, as the standard docker builds are not pushed to Dockerhub for PRs from forked repos (no secrets access). The current CI (ephemeral env) build is leveraging the cache from the current Docker build process, but agreed that the image size is large. I'm working on getting the overall image size down, but on first pass there's not a whole lot of wasted space here. I'm not familiar with Docker, but I was imaging if you have a `Dockerfile` like this: ```dockerfile FROM apache/superset:master # copy latest file contents ... # re-install dependencies ... # rebuild assets ... ``` The saved docker image will contain only the additional layers on top of `apache/superset`, so the image you uploaded to Amazon would be smaller than building Superset from scratch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
