dpgaspar commented on a change in pull request #13223:
URL: https://github.com/apache/superset/pull/13223#discussion_r578978712
##########
File path: superset/databases/api.py
##########
@@ -238,6 +238,7 @@ def post(self) -> Response:
except DatabaseInvalidError as ex:
return self.response_422(message=ex.normalized_messages())
except DatabaseConnectionFailedError as ex:
+ logger.exception("Database connection failed")
Review comment:
I agree with @willbarrett concern, unfortunately some engines dbapi
surface exceptions with sensitive information `logger.warning("Database
connection failed", exc_info=True)` will actually log this info. we can lower
it to `debug`, since on normal situations production systems are not set to
this level.
Also there's an ongoing effort to remap these exceptions at the engine spec
level #12869, so that we can add more granularity to connection failures for
example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
