iercan commented on a change in pull request #13224:
URL: https://github.com/apache/superset/pull/13224#discussion_r579016695
##########
File path: .github/workflows/docker_build_push.sh
##########
@@ -26,7 +26,7 @@ if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
LATEST_TAG="pr-${PR_NUM}"
elif [[ "${GITHUB_EVENT_NAME}" == "release" ]]; then
REFSPEC=$(echo "${GITHUB_REF}" | sed 's:refs/tags/::' | head -c 40)
- LATEST_TAG="${REFSPEC}"
+ LATEST_TAG="latest-release"
Review comment:
In my opinion, latest tag should point to latest released version. All
docker official images also using this convention, because when you pull an
image without a tag, it pulls the latest stable version tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
